Open
Conversation
|
👋 Hi! Please choose at least one reviewer by assigning them on the right bar. |
Anyitechs
force-pushed
the
split-rpc-addr
branch
from
7303c74 to
354137f
Compare
Anyitechs
force-pushed
the
split-rpc-addr
branch
from
354137f to
0f7bc37
Compare
tankyleo
reviewed
Feb 25, 2026
Comment on lines
-155
to
+156
| ChainSource::Rpc { rpc_address, rpc_user, rpc_password } => { | ||
| builder.set_chain_source_bitcoind_rpc( | ||
| rpc_address.ip().to_string(), | ||
| rpc_address.port(), | ||
| rpc_user, | ||
| rpc_password, | ||
| ); | ||
| ChainSource::Rpc { rpc_host, rpc_port, rpc_user, rpc_password } => { | ||
| builder.set_chain_source_bitcoind_rpc(rpc_host, rpc_port, rpc_user, rpc_password); |
Contributor
There was a problem hiding this comment.
Up to you people to make the call, I'd prefer parsing a single <hostname>:<port> string rather than splitting that setting into two parameters. This is what I do in VSS, it optimizes for fewer config params. That setting is logically a single thing right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This splits the
rpc_addressconfiguration field into two fields,rpc_hostandrpc_portto allow hostname support, especially in containerized environments.Closes #66