Skip to content
This repository was archived by the owner on Oct 18, 2023. It is now read-only.

Remove encoding message limit#747

Merged
MarinPostma merged 1 commit intomainfrom
lucio/fix-encoding-max-message-size
Oct 6, 2023
Merged

Remove encoding message limit#747
MarinPostma merged 1 commit intomainfrom
lucio/fix-encoding-max-message-size

Conversation

@LucioFranco
Copy link
Contributor

Users are seeing outofrange errors that I believe are originating from the server side so I removed the encoding limit, while we still have a decoding limit in place.

 Error: Failed to connect to database: `status: OutOfRange, message: "Error, message length too large: found 4225024 bytes, the limit is: 4194304 bytes", details: [], metadata: MetadataMap { headers: {"access-control-allow-credentials": "true", "access-control-expose-headers": "grpc-status,grpc-message,grpc-status-details-bin", "content-type": "application/grpc-web+proto", "date": "Fri, 06 Oct 2023 15:04:56 GMT", "fly-request-id": "01HC2RABMJX2SB2CHHMB8RZF0D-sea", "via": "2 fly.io, 1.1 fly.io", "content-length": "0", "server": "Fly/e440b950 (2023-09-20)", "vary": "origin", "vary": "access-control-request-method", "vary": "access-control-request-headers"} }`
 at Database.sync (/Users/me/Projects/app/node_modules/libsql/index.js:78:22)

@MarinPostma
Copy link
Contributor

This issue will also be improved by #731

@MarinPostma MarinPostma added this pull request to the merge queue Oct 6, 2023
Merged via the queue into main with commit be73866 Oct 6, 2023
@MarinPostma MarinPostma deleted the lucio/fix-encoding-max-message-size branch October 6, 2023 15:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants