This repository was archived by the owner on Oct 18, 2023. It is now read-only.
query_analysis: allow CREATE FUNCTION statement#365
Draft
psarna wants to merge 1 commit intolibsql:mainfrom
Draft
query_analysis: allow CREATE FUNCTION statement#365psarna wants to merge 1 commit intolibsql:mainfrom
psarna wants to merge 1 commit intolibsql:mainfrom
Conversation
psarna
force-pushed
the
create_function_analysis
branch
from
490d28c to
8794ea9
Compare
MarinPostma
reviewed
May 2, 2023
|
|
||
| // Workaround for CREATE FUNCTION. | ||
| // FIXME: this should be handled by the parser (or *at least* trimmed + case insensitive) | ||
| let is_create_function = s.starts_with("CREATE FUNCTION"); |
Contributor
There was a problem hiding this comment.
yeah this needs to be handled by the parser 100%, trimming and case insensitive won't be enough, there can be an arbitrary number of whitespace between create and function
MarinPostma
reviewed
May 2, 2023
Comment on lines
+223
to
+225
| if is_create_function { | ||
| return maybe_create_function_stmt.take(); | ||
| } |
Contributor
There was a problem hiding this comment.
this is not correct, the string can contain multiple statements
| let mut maybe_create_function_stmt = is_create_function.then(|| { | ||
| Ok(Statement { | ||
| stmt: s.to_string(), | ||
| kind: StmtKind::Other, |
Contributor
There was a problem hiding this comment.
This is definitely a write
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft is a showcase of how little it takes to enable Wasm-powered user-defined functions in sqld (and then Turso).
It's just a draft because it shows a cheap workaround for the parser, but we can also cook a more decent solution even without changing the sqlite3-parser crate - and ideally we can just contribute to that, under a
libsqlfeature flag.btw: I needed to put this condition inside
std::iter::from_fnbecause otherwise Rust isn't able to determine a single return type for this function, which isn't ideal, but if we decide to go forward with enabling Wasm udfs in sqld, we can rework that too./cc @MarinPostma @glommer