feat: use image and command-line dimensions by default on sdapi#1262
Draft
wbruna wants to merge 2 commits intoleejet:masterfrom
Draft
feat: use image and command-line dimensions by default on sdapi#1262wbruna wants to merge 2 commits intoleejet:masterfrom
wbruna wants to merge 2 commits intoleejet:masterfrom
Conversation
- actually apply requested cfg_scale - make steps optional - get steps and cfg_scale default values from command line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When image dimensions are not provided, get them first from any input images, replicating the
sd-cliapproach. For plain txt2img, get the default dimensions from the server command-line.This is on top of #1260 because it conflicts with it, and I tested both together; I can rebase it onto master if needed. And if the logic is sound, I'll extend it to the openai endpoints.
Should (eventually) fix #1248 .