chore(deps): bump qs from 6.14.0 to 6.14.2#5702
Conversation
592b3e6 to
9bf5de4
Compare
rtibblesbot
left a comment
There was a problem hiding this comment.
Dependency Update Review
Package: qs 6.14.0 → 6.14.2
Semver risk: Patch
Dependency type: Production
CI status: In progress (no failures; completed checks passing)
Changelog Analysis
Sources consulted:
Breaking changes: None.
Security fixes: None explicitly (no CVEs), though the arrayLimit enforcement fixes harden query string parsing.
Notable changes (6.14.1 + 6.14.2):
- Fixed
arrayLimitto apply consistently to[]notation, indexed notation, and comma-parsed values arrayLimitnow correctly represents max count (not max index) in combine/merge/parseArrayValue- Fixed handling of custom decoders returning
nullfor keys - Robustness improvements (avoid
.push, usevoid) - Refactored key segment splitting into helper
Compatibility Assessment
- Project uses affected APIs: No —
qsis used as a transitive dependency viaexpressandbody-parser, and directly inpackage.json. The fixes relate toarrayLimitandthrowOnLimitExceededoptions that require explicit opt-in. - Peer dependency changes: None
- Code changes required: None
- Lockfile changes: Clean — only
qs(6.14.0→6.14.2) and transitiveqs(6.5.3→6.5.5 viarequest) updated
Recommendation
APPROVE — Low-risk patch bump with bug fixes only. No breaking changes, no API surface changes affecting this project.
rtibblesbot
left a comment
There was a problem hiding this comment.
Dependency Update Review
Package: qs 6.14.0 → 6.14.2 (specifier ^6.11.2 → ^6.14.2)
Semver risk: Patch
Dependency type: Production
CI status: Passing
Changelog Analysis
Sources consulted:
Breaking changes: None.
Security fixes: None.
Notable changes (6.14.1–6.14.2):
- Fixed
arrayLimitenforcement on[]notation, indexed notation overflow, and comma-parsed values - Custom decoder returning
nullfor a key now correctly ignores that key - Robustness improvements (avoid
.push, usevoid) - Documentation and CI maintenance
Compatibility Assessment
This project uses qs.stringify with arrayFormat: 'comma' and a custom encoder in contentcuration/contentcuration/frontend/shared/client.js. All fixes in 6.14.1–6.14.2 target parse behavior (arrayLimit handling, custom decoder null keys) — none affect stringify. No API changes, no new peer dependencies, no code changes required.
Recommendation
APPROVE — patch-level bug fixes to parsing behavior that don't affect this project's stringify-only usage. CI passing.
Bumps [qs](https://github.com/ljharb/qs) from 6.14.0 to 6.14.2. - [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md) - [Commits](ljharb/qs@v6.14.0...v6.14.2) --- updated-dependencies: - dependency-name: qs dependency-version: 6.14.2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
9bf5de4 to
ade978b
Compare
rtibblesbot
left a comment
There was a problem hiding this comment.
Dependency Update Review
Package: qs 6.14.0 → 6.14.2
Semver risk: Patch
Dependency type: Production
CI status: Passing
Changelog Analysis
Sources consulted:
Breaking changes: None.
Security fixes: None explicitly flagged, though fixes to arrayLimit enforcement in parse harden the library against potential abuse via oversized arrays.
Notable changes (v6.14.1 + v6.14.2):
- Multiple fixes to
arrayLimitenforcement inparse: now applies to[]notation,comma-parsed values, and indexed notation throwOnLimitExceedednow throws onarrayLimitexceeded with indexed notation- Custom decoder returning
nullfor a key now ignores that key - Robustness improvements (avoid
.push, usevoid) - Documentation and CI housekeeping
Compatibility Assessment
All changes are on the parse side. This project uses only qs.stringify (in contentcuration/contentcuration/frontend/shared/client.js for query param serialization with arrayFormat: 'comma'). No qs.parse usage found. These fixes have zero impact on this project's usage.
The lockfile also bumps transitive qs@6.5.3 → 6.5.5 (used by request). Same risk profile — patch-level parse fixes.
- Project uses affected APIs: No (only
stringify, notparse) - Peer dependency changes: No
- Code changes required: No
- Prior failed attempts: No
Recommendation
APPROVE — Patch-level update, all changes are parse-side fixes, project only uses stringify, CI passing.
rtibbles
left a comment
There was a problem hiding this comment.
No concerns from changelog - good to merge.
Bumps qs from 6.14.0 to 6.14.2.
Changelog
Sourced from qs's changelog.
Commits
bdcf0c7v6.14.2294db90[readme] document thataddQueryPrefixdoes not add?to empty output5c308e5[readme] clarifyparseArraysandarrayLimitdocumentation6addf8c[Fix]parse: mark overflow objects for indexed notation exceedingarrayLimitcfc108f[Fix]arrayLimitmeans max count, not max index, incombine/merge/`pars...febb644[Fix]parse: throw onarrayLimitexceeded with indexed notation when `thr...f6a7abf[Fix]parse: enforcearrayLimitoncomma-parsed valuesfbc5206[Fix]parse: fix error message to reflect arrayLimit as max index; remove e...1b9a8b4[actions] fix rebase workflow permissions2a35775[meta] fix changelog typo (arrayLength→arrayLimit)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.