-
Notifications
You must be signed in to change notification settings - Fork 0
Deploy storybook #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy storybook #123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
.aws/cfn/storybook.yml:36
- [nitpick] The bucket name pattern 'reactstarter-ui-sb' differs from the domain naming used in Route53 records (e.g., 'react-starter-storybook'). Consider aligning these naming conventions for clarity and consistency across resources.
BucketName: !Sub
- 'reactstarter-ui-sb.${HostedZone}-${AWS::Region}-${AWS::AccountId}'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.
Files not reviewed (1)
- .github/workflows/deploy-qa.yml: Language not supported
Comments suppressed due to low confidence (2)
.github/workflows/deploy-storybook.yml:63
- [nitpick] The input name 'env' is ambiguous; consider renaming it to 'environment_code' or a similarly descriptive name to improve clarity in the deployment configuration.
echo "VITE_BUILD_ENV_CODE=${{ inputs.env }}" >> .env
.github/workflows/deploy-app.yml:64
- [nitpick] Using 'env' as an input name may be unclear; renaming it to 'environment_code' could make the intended purpose more explicit within the workflow.
echo "VITE_BUILD_ENV_CODE=${{ inputs.env }}" >> .env
📢 Instructions
🔧 Change Summary
Describe the changes included in this pull request. Link to the associated GitHub issue(s).
📝 Checklist
Pull request authors must complete the following tasks before marking the PR as ready to review.
🧪 Steps to Test
Describe the process to test the changes in this pull request.
devtag.🔗 Additional Information
Optionally, provide additional details, screenshots, or URLs that may assist the reviewer.