Skip to content

Conversation

@mwarman
Copy link
Member

@mwarman mwarman commented Apr 11, 2025

📢 Instructions

  • Begin with a DRAFT pull request.
  • Follow italicized instructions to add detail to assist the reviewers.
  • After completing all checklist items, change the pull request to READY.

🔧 Change Summary

Describe the changes included in this pull request. Link to the associated GitHub issue(s).

📝 Checklist

Pull request authors must complete the following tasks before marking the PR as ready to review.

  • Complete a self-review of changes
  • Unit tests have been created or updated
  • The code is free of [new] lint errors and warnings
  • Update storybook stories as needed
  • Update project documentation as needed, README, JSDoc, etc.

🧪 Steps to Test

Describe the process to test the changes in this pull request.

Review the checkbox stories in Storybook. In the app...

  1. Go to the Components page.
  2. Click on "Checkbox" in the left-side navigation.
  3. Verify that the content and examples for the Checkbox component are good.

🔗 Additional Information

Optionally, provide additional details, screenshots, or URLs that may assist the reviewer.

  • [...]

@mwarman mwarman self-assigned this Apr 11, 2025
@mwarman mwarman linked an issue Apr 11, 2025 that may be closed by this pull request
@mwarman mwarman requested a review from Copilot April 11, 2025 10:39
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • package.json: Language not supported
Comments suppressed due to low confidence (1)

src/pages/Components/components/CheckboxComponents.tsx:93

  • The description incorrectly refers to the 'Input' component instead of the 'Checkbox' component. Please update the text to accurately reflect that this example demonstrates the Checkbox component.
          The <span className="font-mono font-bold">Input</span> component renders a HTML input element. It is used to capture a single line of text input. The Input component internally uses the Label, HelpText, and FieldError components.

@mwarman mwarman marked this pull request as ready for review April 11, 2025 11:14
@mwarman mwarman requested a review from Copilot April 11, 2025 11:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • package.json: Language not supported

@mwarman mwarman requested a review from Copilot April 11, 2025 11:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • package.json: Language not supported
Comments suppressed due to low confidence (1)

src/pages/Components/components/tests/CheckboxComponents.test.tsx:47

  • [nitpick] The validation error element is asserted twice in this test (once inside waitFor and immediately after). Consider removing the duplicate assertion to improve clarity and reduce redundancy.
expect(screen.getByTestId('checkbox-terms-error')).toBeDefined();

@mwarman mwarman merged commit 58da7b3 into main Apr 11, 2025
5 checks passed
@mwarman mwarman deleted the 94-checkbox-component branch April 11, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Checkbox component

2 participants