Skip to content

Conversation

@mwarman
Copy link
Member

@mwarman mwarman commented Apr 3, 2025

📢 Instructions

  • Begin with a DRAFT pull request.
  • Follow italicized instructions to add detail to assist the reviewers.
  • After completing all checklist items, change the pull request to READY.

🔧 Change Summary

Describe the changes included in this pull request. Link to the associated GitHub issue(s).

  • fixes Replace the yup validation library with zod #106
  • Added the zod library and removed yup
  • Updated the components where yup was used for validation such as forms and the ConfigProvider.
  • Updated all stories and unit tests which depended on yup.

📝 Checklist

Pull request authors must complete the following tasks before marking the PR as ready to review.

  • Complete a self-review of changes
  • Unit tests have been created or updated
  • The code is free of [new] lint errors and warnings
  • Update storybook stories as needed
  • Update project documentation as needed, README, JSDoc, etc.

🧪 Steps to Test

Describe the process to test the changes in this pull request.

View storybook and review the Form components.

Perform a full regression test of the application with specific focus on the sign in form and the task form, both edit and create tasks.

🔗 Additional Information

Optionally, provide additional details, screenshots, or URLs that may assist the reviewer.

  • [...]

@mwarman mwarman linked an issue Apr 3, 2025 that may be closed by this pull request
@mwarman mwarman self-assigned this Apr 4, 2025
@mwarman mwarman requested a review from Copilot April 4, 2025 09:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 17 out of 18 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • package.json: Language not supported
Comments suppressed due to low confidence (1)

src/pages/Tasks/components/Form/tests/TaskForm.test.tsx:50

  • The test title was updated from 'cancelled' to 'submitted', but verify that the test implementation actually simulates a submit action (and calls onSubmitSpy) rather than a cancel action.
it('should call onSubmit when submitted', async () => {

@mwarman mwarman requested a review from Copilot April 4, 2025 10:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 18 out of 19 changed files in this pull request and generated 2 comments.

Files not reviewed (1)
  • package.json: Language not supported

@mwarman mwarman marked this pull request as ready for review April 4, 2025 10:52
@mwarman mwarman merged commit 9bc8171 into main Apr 4, 2025
5 checks passed
@mwarman mwarman deleted the 106-replace-the-yup-validation-library-with-zod branch April 4, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace the yup validation library with zod

2 participants