fix(postgres): remove home crate in favor of std::env::home_dir#4171
Open
ricochet wants to merge 1 commit intolaunchbadge:mainfrom
Open
fix(postgres): remove home crate in favor of std::env::home_dir#4171ricochet wants to merge 1 commit intolaunchbadge:mainfrom
ricochet wants to merge 1 commit intolaunchbadge:mainfrom
Conversation
`home_dir()` was fixed in Rust 1.85 (rust-lang/rust#132515) and un-deprecated in 1.87 (rust-lang/rust#137327). Since our MSRV is 1.86, the function is correct but still carries a deprecation warning until MSRV is bumped to 1.87. This will allow other targets to compile including WebAssembly, see rust-lang/cargo#12297
Author
|
CI on main is broken, but once #4172 lands, this can be rebased and should be green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
home_dir()was fixed in Rust 1.85 (rust-lang/rust#132515) andun-deprecated in 1.87 (rust-lang/rust#137327). Since our MSRV is 1.86, the function is correct but still carries a deprecation warning until MSRV is bumped to 1.87.
This will allow other targets to compile including WebAssembly, see rust-lang/cargo#12297
Does your PR solve an issue?
This is related to #4056 to allow for targeting additional environments. I encountered this when compiling for
wasm32-wasip2. The rust ecosystem is moving off of thehomecrate in favor of std so regardless of desire to support WebAssembly as a target, this will improve portability and maintainability of sqlx.Is this a breaking change?
No