Make whoami an optional feature for postgres#4170
Open
ricochet wants to merge 1 commit intolaunchbadge:mainfrom
Open
Make whoami an optional feature for postgres#4170ricochet wants to merge 1 commit intolaunchbadge:mainfrom
whoami an optional feature for postgres#4170ricochet wants to merge 1 commit intolaunchbadge:mainfrom
Conversation
3114c9f to
354caff
Compare
Make the `whoami` dependency a feature gate (`whoami`) on `sqlx-postgres` so it can be disabled by users who don't need OS username fallback. When disabled, the default username falls back to "unknown" if `PGUSER` is not set. The feature is included in the top-level `sqlx` crate's default features, so existing behavior is preserved. Follows up on launchbadge#1571 and launchbadge#2319.
354caff to
d8d45b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the
whoamidependency a feature gate (whoami) onsqlx-postgresso it can be disabled by users who don't need OS username fallback.The feature is included in the top-level
sqlxcrate's default features, so existing behavior is preserved.Does your PR solve an issue?
This is related to #4056 to allow for targeting additional environments. I encountered this when compiling for
wasm32-wasip2.Follows up on #1571 and #2319 as well as related to change #4143
Is this a breaking change?
No.