Closed
Conversation
The promote job now checks if the package version exists on npm before attempting to add the dist-tag. This prevents failures when a fresh non-prerelease is published, which triggers both 'published' and 'released' events simultaneously. The lightweight promote job would previously race the deploy job and fail when trying to tag a not-yet-published version.
Author
|
Cursor Agent can help with this pull request. Just |
Author
|
Automatically closed this PR because it was created by Bugbot autofix for #66, and that PR was closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bare minimum self-checks
mainPieces of flare
Finally
If you have any issues or need help please join the
#contributorschannel in the Lando slack and someone will gladly help you out!You can also check out the coder guide.
This PR fixes a race condition where the
promotejob would fail during a fresh non-prerelease publication. Previously, thepromotejob would attempt to add thelatestdist-tag before thedeployjob had finished publishing the package to npm, causing an error.The fix introduces a check to verify if the package version already exists on npm before attempting to add the
latestdist-tag. This ensures that thepromotejob only acts on existing prereleases and avoids failing on new releases, preventing misleading workflow failures.