Composer home quiet flag#233
Draft
cursor[bot] wants to merge 1 commit intofix/composer-install-prestissimo-checkfrom
Draft
Composer home quiet flag#233cursor[bot] wants to merge 1 commit intofix/composer-install-prestissimo-checkfrom
cursor[bot] wants to merge 1 commit intofix/composer-install-prestissimo-checkfrom
Conversation
The --quiet flag suppresses all output including the config value itself, causing COMPOSER_HOME detection to fail when not pre-set. Removing --quiet while keeping 2>/dev/null allows the value to be captured while still suppressing stderr warnings.
Author
|
Cursor Agent can help with this pull request. Just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bare minimum self-checks
mainPieces of flare
Finally
If you have any issues or need help please join the
#contributorschannel in the Lando slack and someone will gladly help you out!You can also check out the coder guide.
This PR fixes a bug where the
composer global config homecommand was not correctly detecting the Composer home directory due to the--quietflag suppressing its standard output.The
--quietflag has been removed from the command inscripts/install-composer.shto allow the Composer home path to be captured, ensuring theCOMPOSER_HOMEvariable is correctly set and the subsequent prestissimo removal logic functions as intended. The2>/dev/nullredirection remains to suppress stderr warnings.