Closed
Conversation
Adds an 'edited' trigger to the release workflow with a lightweight 'promote' job that runs npm dist-tag to move 'latest' to the current version. Only fires when a prerelease is changed to a full release (not drafts). The existing publish pipeline remains gated to 'published' events only.
package.json on main may not reflect the released version since prepare-release-action only runs in the deploy job. Using github.event.release.tag_name is more reliable.
- Move tag_name to env variable to prevent shell injection vulnerability - Add prerelease.from check to prevent npm latest tag regression on edits
Author
|
Cursor Agent can help with this pull request. Just |
Author
|
Automatically closed this PR because it was created by Bugbot autofix for #229, and that PR was closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bare minimum self-checks
mainPieces of flare
Finally
If you have any issues or need help please join the
#contributorschannel in the Lando slack and someone will gladly help you out!You can also check out the coder guide.
This PR addresses two issues in the
release.ymlGitHub Actions workflow:github.event.release.tag_namevia an environment variable to prevent shell injection when runningnpm dist-tag add.promotejob's condition to only trigger if a release'sprereleasestatus explicitly changes fromtruetofalse, preventing thelatestnpm tag from regressing when older releases are merely edited.