fix: correct OR null semantics for nullable masks#5919
fix: correct OR null semantics for nullable masks#5919wjones127 merged 5 commits intolance-format:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Hi @wjones127, could you please review this when you have a moment? Thanks! |
wjones127
left a comment
There was a problem hiding this comment.
Could you add this test to https://github.com/lance-format/lance/blob/main/rust/lance/tests/query/primitives.rs ? That's where we want these kind of query tests.
I didn't ask for this on the label list PRs because we don't yet have a nested field test suite merged. I've started them here: #5901
Should just be able to add a filter or two.
Sure, I'll handle this tomorrow. Should I keep the test in Python? |
You can if you want. |
074a65e to
114fe5e
Compare
wjones127
left a comment
There was a problem hiding this comment.
Looks good. Thank you!
closes #5895
Allow|Block ORpreviously assumedNULLrows were always included in theblock.selectedset; when they were not,NULLs could be dropped andFALSE/NULLwere mixed, leading to incorrect results.This change computes
TRUE/FALSE/NULLexplicitly forAllow|Block ORand derivesNULL/selectedsets from those.