Conversation
PR ReviewThanks for adding the Lance user guide skill! This is a useful addition for helping code agents assist Lance users. P1 IssuesDeprecated API usage - The documentation and example script use Affected locations:
Minor Suggestions (non-blocking)
Overall the skill content is well-structured with clear workflow decision trees and troubleshooting patterns. |
| - Equality filters on high-cardinality columns: start with `BTREE` | ||
| - Equality / IN-list filters on low-cardinality columns: start with `BITMAP` | ||
| - Text search: start with `FTS` (or other text index types supported by the version) | ||
| - Range filters: start with range-friendly options (for example `ZONEMAP` when appropriate) |
There was a problem hiding this comment.
we are missing a few here like label list, bloom filter, rtree. Should also mention how to handle json data index.
prrao87
left a comment
There was a problem hiding this comment.
FTS isn't a supported term in the list of indices (only INVERTED works), so I think we should change that.
| - Equality / IN-list filters on low-cardinality columns: start with `BITMAP` | ||
| - List membership filters on list-like columns: start with `LABEL_LIST` | ||
| - Substring / `contains(...)` filters on strings: start with `NGRAM` | ||
| - Text search: start with `INVERTED` |
There was a problem hiding this comment.
| - Text search: start with `INVERTED` | |
| - Full-text search (FTS): start with `INVERTED` |
There was a problem hiding this comment.
I think this will provide better context, as full-text search is an incredibly common term out there in the wild?
This PR adds a basic lance skill as user guide.
Users can install them via
Parts of this PR were drafted with assistance from Codex (with
gpt-5.2) and fully reviewed and edited by me. I take full responsibility for all changes.