faet: Enhance not found errors with suggestions#5865
Open
camilesing wants to merge 1 commit intolance-format:mainfrom
Open
faet: Enhance not found errors with suggestions#5865camilesing wants to merge 1 commit intolance-format:mainfrom
camilesing wants to merge 1 commit intolance-format:mainfrom
Conversation
Contributor
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
camilesing
force-pushed
the
issue__5642
branch
from
cb348f5 to
f9e5265
Compare
wjones127
requested changes
Feb 6, 2026
Contributor
wjones127
left a comment
wjones127
left a comment
There was a problem hiding this comment.
Hey @camilesing are you still working on this?
If so, you can take a look at what I draft here: #5830
It might help you make progress.
And if you continue working on this, make sure to address my comment about not computing the suggestion until the Display implementation is called.
camilesing
force-pushed
the
issue__5642
branch
from
f9e5265 to
bbc3006
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for issue: #5642