Very basic tests for ThingClient #235
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Barecheck - Code coverage reportTotal: 96.01%Your code coverage diff: 0.91% ▴ ✅ All code changes are covered |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ThingClinet is somewhat tested implicitly via other tests using it. But I had an issue with sending variables by
ThingClienton the OpenFlexure Server (turns out it was just an argument error and confusing error messages, see #234).I did realise that there were no explicit tests that ThingClient could send arguments to actions and that these were acted on appropriately.
This PR adds some very basic tests just to make it very clear that ThingClient is doing some very basic things correctly.