Handle BOOKMARK events in watch.py#2505
Handle BOOKMARK events in watch.py#2505k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
Conversation
Verified with python -m unittest kubernetes/watch/watch_test.py. Applied flake8 and isort on impacted lines.
|
|
|
Welcome @note35! |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: note35, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind feature
What this PR does / why we need it:
This PR implements the TODO in watch.py to handle
BOOKMARKevents. Previously,BOOKMARKevents were ignored.Changes included:
unmarshal_eventto extract and updateresource_versionwhen receivingBOOKMARKevents.unmarshal_eventusing guard clauses to improve readability and reduce nesting.Which issue(s) this PR fixes:
It fixes TODO in kubernetes/watch/watch.py, I think no issue is created for this.
Special notes for your reviewer:
Verified with
python -m unittest kubernetes/watch/watch_test.pyApplied flake8 and isort on impacted lines. (No <= 80 characters limitation.)
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
N/A