Skip to content

Conversation

@11-Sarthak
Copy link

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR fixes a crash in _load_from_exec_plugin() where
parse_rfc3339() fails if the exec plugin returns an invalid
expirationTimestamp.

Changes:

  • Wrap parse_rfc3339 in a try-except block
  • Log a clear error message if parsing fails
  • Set self.expiry = None instead of crashing

Which issue(s) this PR fixes:

Prevents Airflow KubernetesPodOperator from crashing with
"'NoneType' object has no attribute 'groups'" error.

Fixes #

Special notes for your reviewer:

No user-facing changes. Only improves error handling.

Does this PR introduce a user-facing change?

No

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels Dec 12, 2025
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 12, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: 11-Sarthak / name: Sarthak (813e251)

@k8s-ci-robot
Copy link
Contributor

Welcome @11-Sarthak!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 11-Sarthak
Once this PR has been reviewed and has the lgtm label, please assign roycaihw for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 12, 2025
@11-Sarthak 11-Sarthak force-pushed the fix-rfc3339-parse-none branch from e5629b7 to 813e251 Compare December 12, 2025 18:58
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants