-
Notifications
You must be signed in to change notification settings - Fork 308
fix: make JsonConverter classes public #1694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make JsonConverter classes public #1694
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR makes JsonConverter classes public to enable custom SourceGeneration configurations. When JsonConverters remain internal, referencing them in custom JsonSourceGenerationOptions causes compilation errors.
Key Changes:
- Changed visibility of all JsonConverter classes from
internaltopublic - Applied changes consistently across both regular and AOT project files
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/KubernetesClient/Models/V1PatchJsonConverter.cs | Changed V1PatchJsonConverter from internal to public |
| src/KubernetesClient/Models/ResourceQuantityJsonConverter.cs | Changed ResourceQuantityJsonConverter from internal to public |
| src/KubernetesClient/Models/IntOrStringJsonConverter.cs | Changed IntOrStringJsonConverter from internal to public |
| src/KubernetesClient.Aot/V1PatchJsonConverter.cs | Changed V1PatchJsonConverter from internal to public in AOT project |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/LGTM the reason i set them to private is that i do not want to hide as much as possible to make crazy change freely :) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IvanJosipovic, tg123 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR updates all the JsonConverters to public
Reason
In order to be able to make custom SourceGeneration configs, the JsonConverters have to be public, otherwise an exception is thrown. Related to #1670
The name 'ResourceQuantity' does not exist in the current context