forked from angular/material
-
Notifications
You must be signed in to change notification settings - Fork 0
No elements on bottom of virtual-repeat container #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ililienthal
wants to merge
2,602
commits into
kseamon:master
Choose a base branch
from
ililienthal:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In readonly mode, the dynamic chips had an additional bit of padding that made them inconsistent with static chips and caused the inner text to not be centered. Fixes angular#2829 (already closed, but people mentioned it in comments)
During animation, certain browsers would show scroll bars if the toast was positioned at the bottom of the parent container. Fix by adding a class to the parent which sets the overflow to hidden only during the animations. Also, update documentation with notes about positioning and recommendations. Fixes angular#2936. Closes angular#6017
I was a bit annoyed I had to hunt this down. I honestly was under the impression that adding the CSS file would be enough to get started just like many other UI frameworks. I was wrong; though not mentioning the module to add in the instructions those give that same impression. Closes angular#6016
In angular#3973 OP addressed us that the color of the input error should be `#DD2C00` which is `A700` from the deep-orange palette so i changed all `warn-500` (the old value from the red palette) to `warn-A700` and change the default warn palette to deep-orange. fixes angular#3973 Closes angular#5992
Added `md-dialog` directive page that contains - `md-dialog`, `md-dialog-content`, `md-dialog-actions`. Added `function` type to controller method fixes angular#4728 and angular#3199 Closes angular#5957
Secondary was being wrapped only if `md-checkbox` or `md-switch` were near by or `ng-click` was applied on the list item. fixes angular#3928 Closes angular#5993
…ormal label without an icon. At the moment the default label selector with (left: 0px) overwrites the label with icon selector. This can be fixed by changing the selector priority. Fixes angular#6005 Closes angular#6013
* add core.spec.js to test ngTouch detection logic Fixes angular#6032. Closes angular#6034
* Refactor Layout API directive registration to iteration all known breakpoints. * Update `layout.spec.js` tests to test all breakpoints Fixes angular#5995. Fixes angular#5983. Closes angular#6037.
* fix parsing issue to allow single value * add demo to test omitting second value fixes angular#5996. closes angular#6003.
There are some common issues that users seem to be experiencing with the different ways that browsers handle flexbox. Add a guide to document these issues with workarounds as well as providing some general guidelines and best practices. Fixes angular#5652. Closes angular#6039
* Some HTML elements can't be flex containers: read https://github.com/philipwalton/flexbugs#9-some-html-elements-cant-be-flex-containers for details. * Add warnings (with url) for above issue. * update checkbox demo with workaround. Closes angular#6024
…und-contrast Contrast made the raised button text color on dark theme to be white, as the button color, Changing that to background-900 made it almost black no-matter the background color. fixes angular#5670 Closes angular#5954
…on to have cursor default fixes angular#4831 Closes angular#5612
Update the docs with better wording and an embeded version of the original Codepen.
…o the body again Closes angular#6044
Accidentally applied zero margin to every `p` in the card, which caused multiple `p` elements to stick together. This fix is only applies zero margin to the first and last element * fixed test with iit Closes angular#6060
* update component custom mediaQueries to be consistent with ranges defined for Layout mediaQueries * update `hide` API for mediaQueries * fix hide SCSS and component mediaQuery(s) * fix mixins for gt-lg and xl * fix flex-order with negative ordering; support -20 to 20 * fix RTE with $log injection * update(layout): Currently `validateAttributeUsage( )` is only used for the `flex` API, so remove its use from the non-observable APIs. * fix menu demos with workarounds for layout=column issues * wrapper div for `<p>` tags * min-height for `<div class="menus">` Fixes angular#5646. Fixes angular#6056. Fixes angular#5576. Fixes angular#6057. Fixes angular#5962. Closes angular#6082,
The logic test deciding when to show the secondary placeholder was backwards, causing the secondary placeholder to be shown when no chips were present. Fixes github issues angular#2770 and angular#4476. Closes angular#6535
- Thx @tjlav5 Fixes angular#6328. Closes angular#6400.
It was bugging me sufficiently. Closes angular#7058
mistakenly enabled for 1.0.5; disable to to Travis fails.
- Add the `clearContext: false` option to hopefully fix the random "some tests reloaded" error. - Create separate CI karma config for all CI-related changes. - improve karma error capture for karma.js - reduce disconnectTimeout 500 mSecs - Update `test-versions.sh` to use CI Karma config and fix typos. References angular#6699. Closes angular#7094
* Defined as auto solved the problem and preserved functionality on Chrome fixes angular#7061 Closes angular#7117
* Also adds test for md-toast-text class in simple toast Fixes angular#6649, #breaking Closes angular#7099
The `line-height` property of the FAB buttons was removed to fix an issue with the tooltip demo. This had unintended consequences on FABs that used `ui-sref` which made them `<a>` tags instead of `<button>` tags. The tooltip demo issue was caused by the parent `<md-content>` applying it's padding to all of it's children. Revert the line-height change and fix demos by wrapping child content in a new `<div>` which accepts the extra padding. Fixes angular#7087. Closes angular#7145
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the fix d27de6d
scrolling with the mousewheel to the bottom of the container dosn't work.
I got a better version.