Skip to content

Conversation

@gauron99
Copy link
Contributor

@gauron99 gauron99 commented Jan 21, 2026

  • instanced go functions as default
  • as instanced signature defaults to "OK" response, change this accordingly in tests (instead of echo response)
  • edit tests to now use instanced function instead of the static one

@knative-prow
Copy link

knative-prow bot commented Jan 21, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 21, 2026
@gauron99 gauron99 changed the title Instanced go functions templates set as default [DNM][WIP]Instanced go functions templates set as default Jan 21, 2026
@gauron99 gauron99 changed the title [DNM][WIP]Instanced go functions templates set as default [DNM][WIP]Instanced go functions template default Jan 21, 2026
@gauron99 gauron99 force-pushed the instanced-funcs branch 2 times, most recently from f9d335e to 73387d9 Compare January 21, 2026 10:00
@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.80%. Comparing base (3837e3a) to head (314e76e).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pkg/deployer/testing/integration_test_helper.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3378      +/-   ##
==========================================
+ Coverage   53.13%   54.80%   +1.66%     
==========================================
  Files         173      173              
  Lines       20096    20112      +16     
==========================================
+ Hits        10679    11023     +344     
+ Misses       8383     8008     -375     
- Partials     1034     1081      +47     
Flag Coverage Δ
e2e 39.62% <ø> (-0.02%) ⬇️
e2e go 35.37% <ø> (-0.05%) ⬇️
e2e node ?
e2e python ?
e2e quarkus ?
e2e rust ?
e2e springboot ?
e2e typescript ?
integration 18.62% <0.00%> (?)
unit macos-14 44.68% <0.00%> (-0.02%) ⬇️
unit macos-latest 44.68% <0.00%> (-0.02%) ⬇️
unit ubuntu-24.04-arm 44.81% <0.00%> (-0.02%) ⬇️
unit ubuntu-latest 45.57% <0.00%> (-0.02%) ⬇️
unit windows-latest 44.70% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gauron99 gauron99 force-pushed the instanced-funcs branch 4 times, most recently from 3fbf389 to 4556925 Compare January 21, 2026 15:11
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 21, 2026
@gauron99 gauron99 changed the title [DNM][WIP]Instanced go functions template default [DNM][WIP] Update templates (instanced signature) Jan 21, 2026
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 22, 2026
@gauron99
Copy link
Contributor Author

/test all

@gauron99 gauron99 force-pushed the instanced-funcs branch 2 times, most recently from b3a6a98 to 9e8a5aa Compare January 22, 2026 18:08
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 22, 2026
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant