fix grammar for unknown vm, fix logic for hardened vm output string#626
Merged
kernelwernel merged 3 commits intokernelwernel:mainfrom Feb 11, 2026
Merged
fix grammar for unknown vm, fix logic for hardened vm output string#626kernelwernel merged 3 commits intokernelwernel:mainfrom
kernelwernel merged 3 commits intokernelwernel:mainfrom
Conversation
…t comment to reflect modifications
Owner
|
thanks for the PR! welcome to the team :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Briefly explain what this PR does:
Removes outdated instructions about opening PRs to the dev branch
Fixes the double "a" in the case of
very_unlikelyandunlikely.Fixes
!hardeneralways evaluating tofalsedue to being aconst char*in this context, I believe we should be checking againstconst bool has_hardener, as a result, this now displays unknown VMs as "an unknown VM" which is grammatically correct, instead of "a unknown VM".Inverts ternary in conclusion so that " VM" is appended when Hyper-V is not present.