Skip to content

annotate Bucket methods with PHP types #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
martinjunger wants to merge 2,635 commits into
base: master
Choose a base branch
from
Draft

annotate Bucket methods with PHP types #882

martinjunger wants to merge 2,635 commits into from

Conversation

@martinjunger
Copy link
Contributor

@martinjunger martinjunger commented Sep 6, 2022 •
edited
Loading

Jira: CT-885

Before asking for review make sure that:

Checklist

  • New client method(s) has tests
  • Apiary file is updated

Release

  • I gave the PR a proper label:
    • major (BC break)
    • minor (new feature)
    • patch (backwards compatible fix)
    • no release (just test changes)

zajca and others added 30 commits May 25, 2022 13:24
@zajca
fix TD pass assert
1af7e6c
@zajca
Merge pull request #807 from keboola/zajca-fix-pass
dda9a67 
fix TD pass assert
@tomasfejfar
Add keboola/coding-standard
58c4e14
@tomasfejfar
Exclude CS not automatically fixable
84f2dd8
@tomasfejfar
Exclude all failing sniffs
fd5dbeb
@tomasfejfar
Merge pull request #802 from keboola/KBC-237-pridat-phpcs-na-storage-…
45a4101 
…api-php-clienta

KBC-237 - Add keboola CS
@tomasfejfar
Generic.Formatting.SpaceAfterCast.NoSpace
d23d0d9
@tomasfejfar
Squiz.WhiteSpace.SuperfluousWhitespace.EmptyLines
30b1a10
@tomasfejfar
PSR2.ControlStructures.ElseIfDeclaration.NotAllowed
d4c9212
@tomasfejfar
SlevomatCodingStandard.Arrays.TrailingArrayComma.MissingTrailingComma
439acd1
@tomasfejfar
Generic.Arrays.DisallowLongArraySyntax.Found
3869669
@tomasfejfar
Squiz.Strings.DoubleQuoteUsage.NotRequired
8a95f1e
@tomasfejfar
Merge pull request #808 from keboola/KBC-237-formatting-fixes
d912cc6 
KBC-237 formatting fixes
@zajca
add TeradataWorkspacesUnloadTest
1c75d21
@zajca
cs fix
92f5dc0
@zajca
Merge pull request #811 from keboola/zajca-kbc-2688
a7386ff 
KBC-2688 add TeradataWorkspacesUnloadTest
@ujovlado
Add license
19f461d
@ujovlado
Merge pull request #813 from keboola/ujovlado-license-and-readme
7a67d19 
Add license
@romanbracinik
remove direct access
e3e6c03
@romanbracinik
baseline
a0063b0
@romanbracinik
Merge pull request #809 from keboola/KBC-2528-cleanup-direct-access
52c58fe 
remove direct access
@tomasfejfar
Make it obvious what should be released
f371c34
@tomasfejfar
Merge pull request #815 from keboola/tomasfejfar-patch-1
c60cb16 
KBC-2699 Make it obvious what should be released
@tomasfejfar
Add apiPostJson missing parameters
0736500
@tomasfejfar
PoC branch metadata is JSON api
bcafedd
@tomasfejfar
Merge pull request #790 from keboola/KBC-2523-endpoints-with-request-…
768ac57 
…objects-enforce-content-type-and-based-on-it-create-from-form-data-or-json-body

KBC-2523 Endpoints with Request Objects enforce content type and based on it create from form data or json body
@martinjunger @tomasfejfar
KBC-1745 deprecate short config calls
be6ba2c
@martinjunger @tomasfejfar
KBC-1745 move deprecated calls to the end of a section
1dfe8d8
@martinjunger @tomasfejfar
KBC-1745 udpate deprecation message
42ce34d
@martinjunger @tomasfejfar
KBC-1745 delete description from deprecated calls
0b9ce2f
martinjunger and others added 18 commits September 2, 2022 09:00
@martinjunger
Merge pull request #872 from keboola/mj-KBC-2814-fix-ro-on-endpoints-…
567966f 
…storage-tokens-controller

KBC-2814 add CreateTokenRequest and CreateLimitedTokenRequest
@martinjunger
fix newlines and typos
732ed48
@martinjunger
add trigger detail to apiary docs
588f5ac
@martinjunger
Merge pull request #876 from keboola/KBC-2815-fix-ro-on-endpoints-sto…
3bb8306 
…rage-triggers-controller-get

KBC-2815 update apiary documentation - add get trigger
@martinjunger
KBC-2815 replace CreateTriggerRequest - update error messages
2444d0f
@martinjunger
Merge pull request #874 from keboola/KBC-2815-fix-ro-on-endpoints-sto…
ee1d7ac 
…rage-triggers-controller

KBC-2815 replace CreateTriggerRequest
@martinjunger
KBC-2761 deprecate post/put/delete methods with form-data
1af2053
@martinjunger
KBC-2761 remove unused method apiDeleteParams
92b5762
@martinjunger
rename delete method
f548fdf
@martinjunger
define missing docs for get/post/put/delete methods
e426785
@martinjunger
send form-data/json content only is defined + method to uppercase
53a95f8
@martinjunger
fix phpstan issues
1919ca0
@martinjunger
revert: rename delete method
591aeb4
@martinjunger
revert: remove unused method apiDeleteParams
219ee56
@martinjunger
revert: send form-data content only is defined
c389aa8
@martinjunger
send json object if data empty
4385b8c
@martinjunger
KBC-2761 migrate Buckets to JSON
edada16
@martinjunger
annotate bucket methods with php types
96132c0
@martinjunger martinjunger force-pushed the KBC-2761-json-buckets branch 5 times, most recently from 6e86aed to 4b8cdb8 Compare September 12, 2022 14:22
@martinjunger martinjunger force-pushed the KBC-2761-json-buckets branch 4 times, most recently from 7ca0f5b to bdab1f3 Compare February 27, 2023 08:36
Base automatically changed from KBC-2761-json-buckets to master February 27, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@martinjunger @zajca @tomasfejfar @ujovlado @romanbracinik @odinuv @jirkasemmler @pivnicek @ErikZigo @pepamartinec