fix: add asChild prop to community section buttons #310
Open
thisisharsh7 wants to merge 1 commit intokagent-dev:mainfrom
Open
fix: add asChild prop to community section buttons #310thisisharsh7 wants to merge 1 commit intokagent-dev:mainfrom
thisisharsh7 wants to merge 1 commit intokagent-dev:mainfrom
Conversation
Signed-off-by: thisisharsh7 <9u.harsh@gmail.com>
thisisharsh7
force-pushed
the
fix/community-buttons-clickable
branch
from
521e256 to
c43b9cd
Compare
Author
|
hey @peterj could you please review and let me know for any changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buttons in the Community section had links nested inside them, making only the text clickable instead of the entire button area.
Fixed by adding
asChildprop to both buttons.