Parallel conversion for large notes #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you for your pull request! I was able to confirm the speedup. Please wait a little longer as I am currently reviewing the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conversion of large notes (~100 pages or more) was relatively slow. This PR parallelizes it a little. Not completely, because
def _create_pdf(self, buf, imglist, renderer_class, enable_link, enable_keyword):is likely still the bottleneck and is not paralelized (I have a branch for it, but have not had the time to go through all the changes).The default worker count is set at max to 8, because in practice even those are not fully used. The conversion time for a large note has dropped for me from ~70 seconds to ~40 seconds.