chore: nuke per-facade schema #1194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-garner-canonical
approved these changes
Nov 19, 2024
Contributor
james-garner-canonical
left a comment
james-garner-canonical
left a comment
There was a problem hiding this comment.
Nice, this makes the generated code a lot easier for humans to look at. Hopefully no users have used XFacade.schema though
Contributor
Author
|
No matches in super-tox collection of charms or COU 🎉 |
dimaqq
force-pushed
the
chore-nuke-per-facade-schema
branch
from
11109f3 to
24b81dc
Compare
Contributor
Author
|
/merge |
dimaqq
force-pushed
the
chore-nuke-per-facade-schema
branch
from
24b81dc to
e9b942b
Compare
Contributor
Author
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Individual _clientNN.py files don't need the schemata inlined, remove that field from codegen.