Open
Conversation
c686a82 to
5860a14
Compare
blakeembrey
commented
Jan 22, 2026
| /argument str must be a string/, | ||
| ); | ||
| }); | ||
| import { parse, combineRanges } from "./index"; |
Member
Author
There was a problem hiding this comment.
Part of the change is removing options.combineRanges in favor of a separate utility. The change is negligible for performance so it could remain an option 🤷
It is a code path that never needs checking if it's included in downstream users code though, and it makes it easier to perf test, which is why I split it apart.
55ff729 to
d94bad8
Compare
02f358a to
06db6e7
Compare
d94bad8 to
391481c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Almost a 100% performance improvement with these parsing changes, notably removing
.split()and removing.trim(), and using a loop instead of a regex to validate numbers. This is the rough order of optimization and improvement:Before:
Removing array assignment (use object return):
Validate number in loop and remove
.trim():Remove
.split()and use string slicing:The parser is fairly similar to
cookienow, so I knew the optimizations to make already. I think there's still something in the handling of missing values but it seems negligible for the effort.