Open
Conversation
94158dd to
0867e12
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## be/improved-parser #59 +/- ##
====================================================
Coverage 100.00% 100.00%
====================================================
Files 1 1
Lines 137 108 -29
Branches 55 40 -15
====================================================
- Hits 137 108 -29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0867e12 to
138232d
Compare
Member
Author
|
Benchmarking results as I refactoring, with some level of noise: Begin: Accept only 1 type: Make parameters optional: Stop validating type: Stop sorting params in format: Notably the type validation during parsing and parameter sorting were the bigger wins. Arguably maybe we should validate, but I do prefer the safe no-throw path of a parser and the strict validation of the formatter. This mirrors other packages like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the improved parser PR, this one takes things further with major breaking changes to the API. It's intended to provide basic performance boosts and ignore things that are likely already occurring upstream or downstream of the package.
Example:
req/resobjects but throws when the header field is missing. This would require upstream to grab it and validate behavior already, negating the need for these shortcuts.parametersoptional for a ~10% perf boost when no parameters present.format(>10% boost when parameters are present)