Draft
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
resolvePropertyconstructor option that allows the caller to lazily resolve property values. This is a companion to jsdom/jsdom#4085.When
resolvePropertyis provided and the declaration is readonly,getPropertyValue()calls the callback on cache miss before falling back to_values. This means all property getters (.fontFamily,.color, etc.) that route throughgetPropertyValue()automatically benefit from lazy resolution.@asamuzaK — this is just a draft for discussion, not meant to be merged as-is. We haven't been able to run the full WPT suite locally to validate it. It's meant as an illustration of an alternative approach to the eager resolution in jsdom/jsdom#4079. Would appreciate your thoughts on whether something like this could work, or if you see issues with the approach.
🤖 Generated with Claude Code