Add support for multi modules projects#31
Open
pilardi wants to merge 1 commit intojohnpoth:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whenever you have a multi-module project, you likely don't want to run the shell on every module of it but on a specific one. Typically in maven you select the project with the
-plflag.This PR makes it so that the plugin skips the shell run if the selected project is not the one currently being built. IE:
will run the shell only in
module1and skip any other modules. Before this change, the shell would have been executed for every module in the project.Impl Note:
Unfortunately maven plugins jars, at least v3.x, are not modularized, by declaring the module exposes conflicting packages in the maven plugins namespace, maven-core clashes with maven-annotations plugins so I had to remove module definition until maven hierarchy is updated to java 9 standards.