Open
Conversation
mateusmaaia
approved these changes
Feb 23, 2023
samuel-silva-track
approved these changes
Feb 25, 2023
samuelmachado
approved these changes
Feb 25, 2023
Collaborator
|
Hello, @ardan-bkennedy, and I recently stepped in to help maintain this project. |
|
Hi @dlsniper and @ardan-bkennedy, yes, it is still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new option to use a "colon" to bind variables.
I did it because the Go-Ora driver can use Named Queries and numbered colons.
But to use named queries, it is required to create objects in the database; in my case, it was impossible.
The alternative we used was to custom bind the driver to DOLLAR and used a regex to change it to numbered colons.
But with this PR now we will be able to use COLON as a bind type directly.