-
Notifications
You must be signed in to change notification settings - Fork 1
fix(gitcommit): remove caret from log range #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Verify .git directory and remove deps/mini.nvim before cloning.
Summary of ChangesHello @jinzhongjia, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses two distinct but important areas: refining how Git commit logs are generated and improving the reliability of dependency installation. It corrects the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes the git log range for release notes by removing the caret, which prevents the starting tag from being included in the log. It also improves the robustness of the test dependency installation script in mise.toml by ensuring a clean clone even if a partial or corrupted directory exists. I have one suggestion to further improve the robustness of the Windows script to align its error handling behavior with the Unix version.
| run_windows = """ | ||
| if (-not (Test-Path deps)) { New-Item -ItemType Directory -Path deps | Out-Null } | ||
| if (-not (Test-Path deps/mini.nvim)) { git clone --depth 1 https://github.com/echasnovski/mini.nvim deps/mini.nvim } | ||
| if (-not (Test-Path deps/mini.nvim/.git)) { Remove-Item -Recurse -Force deps/mini.nvim -ErrorAction SilentlyContinue; git clone --depth 1 https://github.com/echasnovski/mini.nvim deps/mini.nvim } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of -ErrorAction SilentlyContinue can mask failures. If Remove-Item fails for a reason other than the path not existing (e.g., permissions), the error is suppressed, and the script proceeds to git clone, which will then fail with a potentially confusing message. The Unix equivalent command uses &&, which correctly prevents git clone from running if the removal fails.
To make the Windows command more robust and align its behavior with the Unix command, it's better to first check if the directory exists before attempting removal and to use an error action that halts the script on failure.
| if (-not (Test-Path deps/mini.nvim/.git)) { Remove-Item -Recurse -Force deps/mini.nvim -ErrorAction SilentlyContinue; git clone --depth 1 https://github.com/echasnovski/mini.nvim deps/mini.nvim } | |
| if (-not (Test-Path deps/mini.nvim/.git)) { if (Test-Path deps/mini.nvim) { Remove-Item -Recurse -Force deps/mini.nvim -ErrorAction Stop }; git clone --depth 1 https://github.com/echasnovski/mini.nvim deps/mini.nvim } |
Verify .git directory and remove deps/mini.nvim before cloning.