feat: add configurable terminal window title#5293
Open
rabin-io wants to merge 5 commits intojesseduffield:masterfrom
Open
feat: add configurable terminal window title#5293rabin-io wants to merge 5 commits intojesseduffield:masterfrom
rabin-io wants to merge 5 commits intojesseduffield:masterfrom
Conversation
Add a new `gui.terminalTitle` config option that sets the terminal
window title when opening a repository. The default format is
`lazygit::{{repoName}}` (e.g., `lazygit::myproject`).
Features:
- Configurable title format with {{repoName}} placeholder
- Set to empty string to disable terminal title updates
- Hot-reloadable: title updates when config file changes
- Cross-platform support using tcell's SetTitle()
- Windows legacy console fallback using cmd.exe's title command
Example config:
```yaml
gui:
terminalTitle: "lazygit::{{repoName}}"
# or custom formats:
# terminalTitle: "[{{repoName}}] lazygit"
# terminalTitle: "" # disable
```
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Prevent command injection vulnerability by escaping cmd.exe special characters (^, &, |, <, >, %) in the terminal title before passing to the shell command. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Replace silent error swallowing with debug logging so failures can be diagnosed when needed. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Remove control characters (ASCII 0-31 and 127) from the terminal title to prevent malicious or accidental escape sequences from breaking terminal behavior. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Move control character sanitization to a reusable utility function - Add comprehensive unit tests covering various edge cases: - Normal strings and unicode - Control characters (null, escape, newline, tab, etc.) - DEL character (0x7F) - Printable special characters preserved Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new
gui.terminalTitleconfig option that sets the terminalwindow title when opening a repository. The default format is
lazygit::{{repoName}}(e.g.,lazygit::myproject).Features:
Example config: