Skip to content

Semgrep Rule Fix #2595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Akhil-gi wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −0
Open

Semgrep Rule Fix #2595

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1ec1bd
fix: transformerfactory-dtds-not-disabled-100
Feb 3, 2026
8fd2266
Merge pull request #9 from Akhil-gi/fix/semgrep-transformerfactory-dt…
Akhil-gi Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions jme3-plugins/src/xml/java/com/jme3/export/xml/XMLExporter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,9 @@ public void save(Savable object, OutputStream outputStream) throws IOException {
try {
TransformerFactory tfFactory = TransformerFactory.newInstance();
tfFactory.setAttribute("indent-number", indentSpaces);
// Disable external DTD and stylesheet access to prevent XXE attacks
tfFactory.setAttribute("accessExternalDTD", "");
tfFactory.setAttribute("accessExternalStylesheet", "");

Transformer transformer = tfFactory.newTransformer();
transformer.setOutputProperty(OutputKeys.STANDALONE, "yes");
Expand Down
Loading