updated to angular 17.1.2#259
Open
manishsingh10895 wants to merge 5 commits intoitsdevdom:developfrom
Open
Conversation
update package version
Updated versions
update peer deps
Update peer deps
StepaZol
reviewed
Mar 24, 2024
| "name": "angular-notifier", | ||
| "description": "A well designed, fully animated, highly customizable, and easy-to-use notification library for your Angular application.", | ||
| "version": "14.0.0", | ||
| "version": "14.1.0", |
Contributor
There was a problem hiding this comment.
I think you are adding breaking changes and the version should be 15
StepaZol
reviewed
Mar 24, 2024
Comment on lines
+16
to
+23
| // Object.defineProperty(document.body.style, 'transform', { | ||
| // value: () => { | ||
| // return { | ||
| // enumerable: true, | ||
| // configurable: true, | ||
| // }; | ||
| // }, | ||
| // }); |
Contributor
There was a problem hiding this comment.
if it's no longer needed, why are you commenting this code? maybe remove it?
Author
There was a problem hiding this comment.
I wasn't sure about the working of this code, so didn't remove it at first.
|
i just add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated packages.
I ran
ncuto update package versionsAlso this is first hacking around with jest in angular, and in
jest.setup.tsline 16, updatingtransformproperty threw an error on running tests.I have commented that code out, it works and as far as I google that workaround isn't needed anymore