Skip to content

Conversation

@pascal-roth
Copy link
Collaborator

@pascal-roth pascal-roth commented Dec 17, 2025

Description

omni.metrics is not part of IsaacSim 4.5, PR restores backward compatibility.

Fixes #4229

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@pascal-roth pascal-roth self-assigned this Dec 17, 2025
@github-actions github-actions bot added bug Something isn't working isaac-lab Related to Isaac Lab team labels Dec 17, 2025
@kellyguo11 kellyguo11 moved this to In review in Isaac Lab Dec 18, 2025
@pascal-roth
Copy link
Collaborator Author

all tests are passing, only /workspace/isaaclab/source/isaaclab_rl/test/test_skrl_wrapper.py times out

pass
# logger.info(f"Could not get Sdf layer for {usd_path}")
else:
from omni.metrics.assembler.core import get_metrics_assembler_interface
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this still doesn't work for isaac sim version less than 4.5, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'omni.metrics' is not available in IsaacSim 4.5, that's why we check before to see if our Isaac version is smaller than 5.0, then we never run the code that wants to import it. We don't maintain compatibility with smaller 4.5 but why should it not work for these versions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working isaac-lab Related to Isaac Lab team

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

[Bug Report] No module named ‘omni.metrics’

3 participants