-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Fixes backward compatibility to IsaacSim 4.5 for new stage utils #4230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fixes backward compatibility to IsaacSim 4.5 for new stage utils #4230
Conversation
|
all tests are passing, only |
| pass | ||
| # logger.info(f"Could not get Sdf layer for {usd_path}") | ||
| else: | ||
| from omni.metrics.assembler.core import get_metrics_assembler_interface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this still doesn't work for isaac sim version less than 4.5, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'omni.metrics' is not available in IsaacSim 4.5, that's why we check before to see if our Isaac version is smaller than 5.0, then we never run the code that wants to import it. We don't maintain compatibility with smaller 4.5 but why should it not work for these versions?
Description
omni.metricsis not part of IsaacSim 4.5, PR restores backward compatibility.Fixes #4229
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there