Always use ZMQ stream not socket in dispatch_shell#1432
Closed
ianthomas23 wants to merge 1 commit intoipython:mainfrom
Closed
Always use ZMQ stream not socket in dispatch_shell#1432ianthomas23 wants to merge 1 commit intoipython:mainfrom
ianthomas23 wants to merge 1 commit intoipython:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently using a ZMQ socket not stream here:
ipykernel/ipykernel/kernelbase.py
Line 421 in 39d4c74
which can cause problems downstream (e.g. in
qtconsole,jupyterlab) when a stream is expected rather than a socket. So here switching to using a stream. This uses an optionalSocketPair.from_streamwhich is only used for the main/subshell to shell channel socket pairs.