fix: Proper scroll lock handling for nested modals #2127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add modalDepth store to track open modal count - Add onModalOpened/onModalClosed callbacks to preserve/restore scroll state - Add reusable Popup component for consistent modal wrapper - Update +layout.svelte to wrap app in Modal with proper callbacks - Update ChannelCard, FeedList/Item, FeedsCard to use Modal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix scroll lock handling when opening/closing nested modals.
Changes
modalDepthstore to track open modal countonModalOpened/onModalClosedcallbacks to preserve/restore scroll statePopupcomponent for consistent modal wrapper+layout.svelteto wrap app in Modal with proper callbacksChannelCard,FeedList/Item,FeedsCardto use ModalTesting
Verify that nested modals work correctly: