BFD config on Bird uses a daemon configuration template #3042
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors how BFD is configured for the Bird daemon by moving BFD protocol configuration out of the generic protocols.j2 and into its own daemon-specific configuration template that is wired via daemon_config.
Changes:
- Remove the inlined
protocol bfddefinition fromnetsim/daemons/bird/protocols.j2. - Introduce
netsim/daemons/bird/bfd.j2as a dedicated BFD daemon configuration template using the same BFD settings logic as before. - Register
/etc/bird/bfd.confinnetsim/daemons/bird.ymlas a daemon configuration file and remove the now-redundant Ansible stub templatenetsim/ansible/templates/bfd/bird.j2.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
netsim/daemons/bird/protocols.j2 |
Drops the embedded BFD protocol block so BFD config comes from a separate daemon config file instead of the shared protocols template. |
netsim/daemons/bird/bfd.j2 |
New daemon template that renders the protocol bfd stanza based on bfd settings and BGP interfaces, to be included via /etc/bird/bfd.conf. |
netsim/daemons/bird.yml |
Extends daemon_config to add a bfd: /etc/bird/bfd.conf entry so Bird’s main config can include a separate BFD config file. |
netsim/ansible/templates/bfd/bird.j2 |
Removes the obsolete shell stub that previously documented that Bird BFD config lived in daemon/bird/protocols.j2. |
| @@ -0,0 +1,10 @@ | |||
| {% if bfd is defined %} | |||
There was a problem hiding this comment.
Doesn't hurt, but shouldn't this be implied by the fact that this file is getting included?
There was a problem hiding this comment.
Yeah, that happens when you say "this is easy enough for an AI agent to solve" and then glance at it and have another AI agent review it 🤷♂️🤦♂️. Proves that they definitely lack the bigger picture.
There was a problem hiding this comment.
AI is likely to implement what it is told to do - it depends on the prompt
No description provided.