Skip to content

Conversation

@rvagg
Copy link
Member

@rvagg rvagg commented Aug 21, 2025

Swap's me and @masih in admin so I can get stuff done, unless you want to be entirely removed @masih?
Removes the strict master protection so I can get stuff merged with fewer people around.
cc @willscott

@rvagg rvagg requested review from a team as code owners August 21, 2025 06:01
@github-actions
Copy link
Contributor

The following access changes will be introduced as a result of applying the plan:

Access Changes
User masih:
  - will have the permission to go-car change from admin to push
User rvagg:
  - will have the permission to go-car change from push to admin

@github-actions
Copy link
Contributor

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

ipld

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  ~ update in-place
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # github_branch_protection.this["go-car:master"] will be updated in-place
  ~ resource "github_branch_protection" "this" {
        id                              = "BPR_kwDOCJHP3M4CIekZ"
        # (11 unchanged attributes hidden)

      - required_pull_request_reviews {
          - dismiss_stale_reviews           = false -> null
          - dismissal_restrictions          = [] -> null
          - pull_request_bypassers          = [] -> null
          - require_code_owner_reviews      = true -> null
          - require_last_push_approval      = false -> null
          - required_approving_review_count = 1 -> null
          - restrict_dismissals             = false -> null
        }
    }

  # github_repository_collaborator.this["go-car:masih"] must be replaced
-/+ resource "github_repository_collaborator" "this" {
      ~ id                          = "go-car:masih" -> (known after apply)
      + invitation_id               = (known after apply)
      ~ permission                  = "admin" -> "push" # forces replacement
      + permission_diff_suppression = false
        # (2 unchanged attributes hidden)
    }

  # github_repository_collaborator.this["go-car:rvagg"] will be created
  + resource "github_repository_collaborator" "this" {
      + id                          = (known after apply)
      + invitation_id               = (known after apply)
      + permission                  = "admin"
      + permission_diff_suppression = false
      + repository                  = "go-car"
      + username                    = "rvagg"
    }

Plan: 2 to add, 1 to change, 1 to destroy.

Copy link
Member

@willscott willscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with reducing the protections

@galargh galargh merged commit 2faabc0 into master Aug 21, 2025
6 checks passed
@galargh galargh deleted the rvagg/go-car branch August 21, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants