-
Notifications
You must be signed in to change notification settings - Fork 11
Unarchive py-cid #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unarchive py-cid #102
Conversation
|
The following access changes will be introduced as a result of applying the plan: Access Changes |
|
Before merge, verify that all the following plans are correct. They will be applied as-is after the merge. Terraform plansipld |
|
Thanks for doing this. |
BigLep
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rvagg's suggested changes look good to me.
Co-authored-by: Rod Vagg <rod@vagg.org>
Co-authored-by: Rod Vagg <rod@vagg.org>
|
@galargh why does the action keep on undoing my changes? See commit list and its fixes: https://github.com/ipld/github-mgmt/pull/102/commits |
Ah! That's an edge case. It's because the repo is currently archived. In that case, the fix workflow sets all the other values, apart from the archived status, in the config to what they are in GitHub at the moment. We're working around a shortcoming of underlying gh provider this way - it doesn't know unarchiving should come before any other operation on an archived repo. To get us out of this loop, let's:
|
|
Replacing this one with #104 |
Summary
We would like to take on maintenance of the py-cid repo. See ipld/ipld#353 (comment)
I've taken what look like good defaults based on other projects in the file. Please let me know if I've missed something.
Why do you need this?
We are maintaining py-multiaddr, which has py-cid as a dependency.
What else do we need to know?
DRI: myself
@acul71 @seetadev
Reviewer's Checklist