Skip to content

Conversation

@pacrob
Copy link

@pacrob pacrob commented Aug 13, 2025

Summary

We would like to take on maintenance of the py-cid repo. See ipld/ipld#353 (comment)

I've taken what look like good defaults based on other projects in the file. Please let me know if I've missed something.

Why do you need this?

We are maintaining py-multiaddr, which has py-cid as a dependency.

What else do we need to know?

DRI: myself

@acul71 @seetadev

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

@pacrob pacrob requested review from a team as code owners August 13, 2025 23:32
@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2025

The following access changes will be introduced as a result of applying the plan:

Access Changes
User rvagg:
  - will have the permission to py-cid change from pull to push

@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2025

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

ipld

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  ~ update in-place

Terraform will perform the following actions:

  # github_repository.this["py-cid"] will be updated in-place
  ~ resource "github_repository" "this" {
        id                          = "py-cid"
        name                        = "py-cid"
        # (33 unchanged attributes hidden)

      ~ security_and_analysis {

          ~ secret_scanning {
              ~ status = "disabled" -> "enabled"
            }

          ~ secret_scanning_push_protection {
              ~ status = "disabled" -> "enabled"
            }
        }
    }

  # github_team_membership.this["python team:acul71"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = "2474599"
      + username = "acul71"
    }

  # github_team_membership.this["python team:pacrob"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = "2474599"
      + username = "pacrob"
    }

  # github_team_membership.this["python team:rvagg"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = "2474599"
      + username = "rvagg"
    }

  # github_team_membership.this["python team:seetadev"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = "2474599"
      + username = "seetadev"
    }

Plan: 4 to add, 1 to change, 0 to destroy.

@dhuseby
Copy link

dhuseby commented Aug 14, 2025

Thanks for doing this.

Copy link
Contributor

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rvagg's suggested changes look good to me.

pacrob and others added 3 commits August 14, 2025 13:05
Co-authored-by: Rod Vagg <rod@vagg.org>
Co-authored-by: Rod Vagg <rod@vagg.org>
@pacrob
Copy link
Author

pacrob commented Aug 14, 2025

Thanks for your help @rvagg . Suggestions applied. I left in the web3-bot per @galargh's comment, let me know if that should go.

@rvagg
Copy link
Member

rvagg commented Aug 15, 2025

@galargh why does the action keep on undoing my changes? See commit list and its fixes: https://github.com/ipld/github-mgmt/pull/102/commits

@galargh
Copy link
Contributor

galargh commented Aug 18, 2025

@galargh why does the action keep on undoing my changes? See commit list and its fixes: https://github.com/ipld/github-mgmt/pull/102/commits

Ah! That's an edge case. It's because the repo is currently archived. In that case, the fix workflow sets all the other values, apart from the archived status, in the config to what they are in GitHub at the moment. We're working around a shortcoming of underlying gh provider this way - it doesn't know unarchiving should come before any other operation on an archived repo.

To get us out of this loop, let's:

  1. first, merge Unarchive py-cid (no changes) #103 which unarchives py-cid only without making any other changes (once we merge it, the update workflow will update this PR)
  2. then, update this PR with any post-unarchival changes we want to make and merge it.

rvagg added a commit that referenced this pull request Aug 19, 2025
rvagg added a commit that referenced this pull request Aug 19, 2025
@rvagg rvagg mentioned this pull request Aug 19, 2025
@rvagg
Copy link
Member

rvagg commented Aug 19, 2025

Replacing this one with #104

@rvagg rvagg closed this Aug 19, 2025
rvagg added a commit that referenced this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants