gateway: car-* request query parameters #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 17, 2024
lidel
force-pushed
the
gateway-car-parms
branch
from
f0c8f2b to
1defdd3
Compare
lidel
approved these changes
Apr 17, 2024
Member
There was a problem hiding this comment.
Thanks!
Rebased and clarified how they interact with Content-Location.
For anyone following:
- Documenting use of
Content-Locationin #471 allowed us to introduce these query parameters safely, in a way that is backward compatible (Acceptheader taking priority overformatquery parameter,Content-Typeof response being the final source of truth for the client). - No IPIP as these CAR content type parameters were already present in
AcceptandContent-Type. Documenting their query versions is a formality to allow exposing them inContent-Location, which in turn allows implementations to ensure unique cache key for requests with parameters other than the implicit defaults.- tldr: this allows gateways to cache different CAR response variants without overriding each of them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ipfs/boxo#604.