Skip to content

Conversation

@cstamas
Copy link
Collaborator

@cstamas cstamas commented Jan 21, 2026

Modularize with overhauled dependencies.

Changes:

From now on, to update anything in the build (any plugin or dependency) one needs to maintain checksums as well: one can do it by using -Daether.artifactResolver.postProcessor.trustedChecksums.record user property in a trusted environment. Then immediately validating in some independent env (like CI is -- build should pass, otherwise trusted environment is compromised).

But for this we need a ground up (dependencies) overhaul.
@@ -0,0 +1,9 @@
module io.ipfs.http.client {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

java-ipfs-http-client is the only project having module name != package name. Do we want to change anything about it?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave this up to you.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd align those, but TBH am not happy with package name either, is too generic: io.ips.api does not include neither protocol (HTTP) neither any other designator that could make it differentiate from any other "api-like libraries". But IMO aligning to Java package should be ok.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligned them.

@cstamas cstamas marked this pull request as ready for review January 23, 2026 11:30
@cstamas cstamas requested a review from ianopolous January 23, 2026 11:30
@cstamas cstamas requested a review from ianopolous January 23, 2026 11:41
@cstamas
Copy link
Collaborator Author

cstamas commented Jan 23, 2026

Locked down whole build. Build will fail if any used artifacts (build related, like plugin or dependency) changes or being messed with: sha512 checksum mismatches or artifact has no sha512 enlisted here.

@cstamas
Copy link
Collaborator Author

cstamas commented Jan 23, 2026

From now on, if anything is changing (on purpose), checksums needs adjusting. It can happen manually (tedious but works), or it can be updated "in bulk": in trusted environment rebuild with added -Daether.artifactResolver.postProcessor.trustedChecksums.record user property (and when checking in changes watch for .bak files, to not add them). Next, immediately validate changes on unrelated environment (like CI)

@cstamas
Copy link
Collaborator Author

cstamas commented Jan 23, 2026

@cstamas
Copy link
Collaborator Author

cstamas commented Jan 23, 2026

Ready for merge.

@cstamas cstamas merged commit 243fcda into master Jan 23, 2026
1 check passed
@cstamas cstamas deleted the fix/modularize branch January 23, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants