-
Notifications
You must be signed in to change notification settings - Fork 241
Fix: modularize #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: modularize #269
Conversation
But for this we need a ground up (dependencies) overhaul.
c9a5390 to
eea79da
Compare
src/main/java/module-info.java
Outdated
| @@ -0,0 +1,9 @@ | |||
| module io.ipfs.http.client { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
java-ipfs-http-client is the only project having module name != package name. Do we want to change anything about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave this up to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd align those, but TBH am not happy with package name either, is too generic: io.ips.api does not include neither protocol (HTTP) neither any other designator that could make it differentiate from any other "api-like libraries". But IMO aligning to Java package should be ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aligned them.
|
Locked down whole build. Build will fail if any used artifacts (build related, like plugin or dependency) changes or being messed with: sha512 checksum mismatches or artifact has no sha512 enlisted here. |
|
From now on, if anything is changing (on purpose), checksums needs adjusting. It can happen manually (tedious but works), or it can be updated "in bulk": in trusted environment rebuild with added |
|
The stats with PR: |
|
Ready for merge. |
Modularize with overhauled dependencies.
Changes:
module-info.javaFrom now on, to update anything in the build (any plugin or dependency) one needs to maintain checksums as well: one can do it by using
-Daether.artifactResolver.postProcessor.trustedChecksums.recorduser property in a trusted environment. Then immediately validating in some independent env (like CI is -- build should pass, otherwise trusted environment is compromised).