This repository was archived by the owner on Apr 2, 2018. It is now read-only.
Ionic Native 3.x#199
Open
vknabel wants to merge 4 commits intoionic-team:masterfrom
vknabel:bugfix/explicit-dependency
Open
Ionic Native 3.x#199vknabel wants to merge 4 commits intoionic-team:masterfrom vknabel:bugfix/explicit-dependency
vknabel wants to merge 4 commits intoionic-team:masterfrom
vknabel:bugfix/explicit-dependency
Conversation
danielsogl
suggested changes
May 13, 2017
| "superagent": "1.7.2", | ||
| "@ionic/db": "^0.1.0" | ||
| }, | ||
| "peerDependencies": { |
There was a problem hiding this comment.
can you upgrade the dependencies to native 3.6.1?
Author
|
How shall I resolve the merge conflicts? Shall I retain |
|
Without understanding anything else what you did here: |
Author
|
@piotrowski Yes I know. I just don't know wether those changes were just a temporary and hacky workaround or wether they were meant to stay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. We want to use Ionic Native 3.x, which is currently not possible with
@ionic/cloud@0.16.0.As #190 has been opened a while ago, I wanted to help with this.
As all native plugins have to be instantiated (ideally through injection), I added them to the
DIContainerclass.When trying
npm run buildit failed on master.