[CI] Simplify Docker containers by sarnex · Pull Request #21175 · intel/llvm

sarnex · 2026-01-29T18:23:10Z

Get rid of the base container and the current latest container and move the current intel_drivers alldeps container to latest.

Nobody was using the base container directly, and it's only used in one place transitively, the UR liboffload workflow, through the intel_drivers:latest tag.

Lets just simply everything.

This PR isn't updating any workflows because we need the containers in this PR to be published first.

sarnex · 2026-01-29T22:05:00Z

.github/workflows/sycl-coverity.yml

    runs-on: [Linux, build]
    container:
-      image: ghcr.io/intel/llvm/ubuntu2404_intel_drivers:alldeps
+      image: ghcr.io/intel/llvm/ubuntu2404_intel_drivers:latest


Gone from PR

sarnex · 2026-01-29T22:05:06Z

.github/workflows/sycl-linux-run-tests.yml

      packages: read
    container:
-      image: ${{ inputs.image || 'ghcr.io/intel/llvm/ubuntu2404_intel_drivers:alldeps'}}
+      image: ${{ inputs.image || 'ghcr.io/intel/llvm/ubuntu2404_intel_drivers:latest'}}


Gone from PR

sarnex · 2026-01-29T22:05:05Z

.github/workflows/ur-build-offload.yml

    runs-on: [ "Linux", "build" ]
    container:
-      image: 'ghcr.io/intel/llvm/ubuntu2404_base'
+      image: 'ghcr.io/intel/llvm/ubuntu2404_build'


Gone from PR

Signed-off-by: Nick Sarnie <nick.sarnie@intel.com>

YuriPlyakhin · 2026-01-30T01:15:32Z

sycl/doc/developer/DockerBKMs.md


- `devops/containers/ubuntu2204_base`: contains basic environment
-   setup for building DPC++ compiler from source.
 - `devops/containers/ubuntu2204_intel_drivers`: contains everything from the


nit
should we rename it to be ubuntu2204_all_gpu_drivers?

Yeah good idea, let me just name it ubuntu2204_gpu_drivers

Actually thinking now, build has the amd/nvidia drivers and only this one has the intel one, so i think the current naming makes sense

YuriPlyakhin · 2026-01-30T01:18:50Z

sycl/doc/developer/DockerBKMs.md

+   dependencies.json. The drivers are tested/validated everytime we upgrade
+   the driver. Also includes the development kits for NVidia/AMD.
+   The drivers are installed as it is, not tested or validated.
 - `devops/containers/ubuntu2204_build`: has development kits installed for


nit
should we describe ubuntu2204_build first, since we refer to it in ubuntu2204_intel_drivers and then in description of ubuntu2204_intel_drivers we can avoid repeating what we already described for build image.

Makes sense, thanks. I just lazily deleted what was there :)

YuriPlyakhin · 2026-01-30T01:20:23Z

sycl/doc/developer/DockerBKMs.md

-   other drivers are downloaded from release/tag and saved in dependencies.json.
-   * `alldeps`: Includes the same Intel drivers as `latest`, as well as the
-   development kits for NVidia/AMD from the `ubuntu2404_build` Dockerfile.
+   build Dockerfile + pre-installed Intel drivers.


nit. same here.

YuriPlyakhin

LGTM. few nits.

devops/containers/ubuntu2404_base.Dockerfile

sycl/doc/developer/DockerBKMs.md

.github/workflows/sycl-containers.yaml

Signed-off-by: Nick Sarnie <nick.sarnie@intel.com>

lukaszstolarczuk

lgtm 👍

devops/containers/ubuntu2204_build.Dockerfile

devops/containers/ubuntu2404_build.Dockerfile

YuriPlyakhin · 2026-01-30T18:57:59Z

sycl/doc/developer/DockerBKMs.md

+   the driver. Also includes the development kits for NVidia/AMD.
+   The drivers are installed as it is, not tested or validated.


nit - removed duplication

Suggested change

the driver. Also includes the development kits for NVidia/AMD.

The drivers are installed as it is, not tested or validated.

the driver. NVidia/AMD drivers are installed as it is, not tested or validated.

nevermind, you're right, thanks

Signed-off-by: Nick Sarnie <nick.sarnie@intel.com>

KornevNikita · 2026-01-30T22:00:36Z

For some reason trivy ignores the ignorefile. Feel free to ignore, I'll fix it

sarnex · 2026-02-02T15:02:48Z

@uditagarwal97 Mind taking a final look at this one? Thanks

uditagarwal97

LGTM

sarnex · 2026-02-02T15:21:28Z

Thanks! After the containers build I will make a follow-up PR that actually uses these new containers.

Start using the new container labels added in #21175 Signed-off-by: Nick Sarnie <nick.sarnie@intel.com>

sarnex temporarily deployed to WindowsCILock January 29, 2026 18:23 — with GitHub Actions Inactive

github-advanced-security bot found potential problems Jan 29, 2026

View reviewed changes

sarnex temporarily deployed to WindowsCILock January 29, 2026 18:49 — with GitHub Actions Inactive

sarnex had a problem deploying to WindowsCILock January 29, 2026 19:05 — with GitHub Actions Error

sarnex temporarily deployed to WindowsCILock January 29, 2026 19:05 — with GitHub Actions Inactive

sarnex force-pushed the fixdocker branch from a2792eb to c74e3e0 Compare January 29, 2026 19:37

sarnex had a problem deploying to WindowsCILock January 29, 2026 19:38 — with GitHub Actions Error

sarnex force-pushed the fixdocker branch from c74e3e0 to 6acefce Compare January 29, 2026 19:50

sarnex had a problem deploying to WindowsCILock January 29, 2026 19:50 — with GitHub Actions Error

[CI] Simplify Docker containers

081b425

Signed-off-by: Nick Sarnie <nick.sarnie@intel.com>

sarnex force-pushed the fixdocker branch from 6acefce to 081b425 Compare January 29, 2026 19:52

sarnex temporarily deployed to WindowsCILock January 29, 2026 19:52 — with GitHub Actions Inactive

sarnex temporarily deployed to WindowsCILock January 29, 2026 20:35 — with GitHub Actions Inactive

sarnex had a problem deploying to WindowsCILock January 29, 2026 20:35 — with GitHub Actions Failure

sarnex temporarily deployed to WindowsCILock January 29, 2026 20:35 — with GitHub Actions Inactive

sarnex temporarily deployed to WindowsCILock January 29, 2026 21:03 — with GitHub Actions Inactive

sarnex marked this pull request as ready for review January 29, 2026 22:08

sarnex requested review from a team as code owners January 29, 2026 22:08

sarnex requested review from KornevNikita and uditagarwal97 January 29, 2026 22:08

YuriPlyakhin reviewed Jan 30, 2026

View reviewed changes

YuriPlyakhin approved these changes Jan 30, 2026

View reviewed changes

lukaszstolarczuk reviewed Jan 30, 2026

View reviewed changes

devops/containers/ubuntu2404_base.Dockerfile Show resolved Hide resolved

devops/containers/ubuntu2404_base.Dockerfile Show resolved Hide resolved

sycl/doc/developer/DockerBKMs.md Outdated Show resolved Hide resolved

.github/workflows/sycl-containers.yaml Show resolved Hide resolved

address feedback

23771c0

Signed-off-by: Nick Sarnie <nick.sarnie@intel.com>

sarnex temporarily deployed to WindowsCILock January 30, 2026 15:26 — with GitHub Actions Inactive

sarnex temporarily deployed to WindowsCILock January 30, 2026 15:50 — with GitHub Actions Inactive

lukaszstolarczuk reviewed Jan 30, 2026

View reviewed changes

devops/containers/ubuntu2204_build.Dockerfile Outdated Show resolved Hide resolved

devops/containers/ubuntu2404_build.Dockerfile Outdated Show resolved Hide resolved

YuriPlyakhin reviewed Jan 30, 2026

View reviewed changes

address feedback 2

34b0bf5

Signed-off-by: Nick Sarnie <nick.sarnie@intel.com>

sarnex had a problem deploying to WindowsCILock January 30, 2026 19:11 — with GitHub Actions Error

stupid emacs

4d7f1e7

Signed-off-by: Nick Sarnie <nick.sarnie@intel.com>

sarnex temporarily deployed to WindowsCILock January 30, 2026 19:13 — with GitHub Actions Inactive

sarnex temporarily deployed to WindowsCILock January 30, 2026 19:34 — with GitHub Actions Inactive

remove duplication

419bb26

Signed-off-by: Nick Sarnie <nick.sarnie@intel.com>

sarnex temporarily deployed to WindowsCILock January 30, 2026 19:55 — with GitHub Actions Inactive

sarnex had a problem deploying to WindowsCILock January 30, 2026 20:19 — with GitHub Actions Failure

sarnex temporarily deployed to WindowsCILock January 30, 2026 20:19 — with GitHub Actions Inactive

sarnex temporarily deployed to WindowsCILock January 30, 2026 22:03 — with GitHub Actions Inactive

uditagarwal97 approved these changes Feb 2, 2026

View reviewed changes

sarnex merged commit 466d0d5 into intel:sycl Feb 2, 2026
55 of 61 checks passed

sarnex mentioned this pull request Feb 3, 2026

[CI] Use new Docker containers #21205

Merged

sarnex added a commit that referenced this pull request Feb 3, 2026

[CI] Use new Docker containers (#21205)

2fa4d81

Start using the new container labels added in #21175 Signed-off-by: Nick Sarnie <nick.sarnie@intel.com>

		the driver. Also includes the development kits for NVidia/AMD.
		The drivers are installed as it is, not tested or validated.

	the driver. Also includes the development kits for NVidia/AMD.
	The drivers are installed as it is, not tested or validated.
	the driver. NVidia/AMD drivers are installed as it is, not tested or validated.

Conversation

sarnex commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Check failure

Choose a reason for hiding this comment

Uh oh!

Check failure

Choose a reason for hiding this comment

Uh oh!

Check failure

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

YuriPlyakhin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lukaszstolarczuk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KornevNikita commented Jan 30, 2026

Uh oh!

sarnex commented Feb 2, 2026

Uh oh!

uditagarwal97 left a comment

Choose a reason for hiding this comment

Uh oh!

sarnex commented Feb 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sarnex commented Jan 29, 2026 •

edited

Loading