Skip to content

[SYCL][GRAPH] fix infinite loop bug in tryReuseExistingAllocation#21170

Merged
sarnex merged 3 commits intointel:syclfrom
lslusarczyk:tryReuseExistingAllocation-infinite-loop-fix
Feb 3, 2026
Merged

[SYCL][GRAPH] fix infinite loop bug in tryReuseExistingAllocation#21170
sarnex merged 3 commits intointel:syclfrom
lslusarczyk:tryReuseExistingAllocation-infinite-loop-fix

Conversation

@lslusarczyk
Copy link
Contributor

Bug introduced in #19049
The bug causes llama CLI hang on any prompt if llama is run with graphs. After the fix llama CLI works.

@reble , there is a gap in sycl graphs unittesting which do not covered this case. You may consider adding some full-app (like llama CLI) graphs functional tests, which could also easily catch such issues.

@lslusarczyk
Copy link
Contributor Author

@reble , CI is all green, please review this one-line fix and approve if it is OK

@reble
Copy link
Contributor

reble commented Jan 30, 2026

@lslusarczyk Thanks for spotting this. CI was green before. We should add a regression test.
@mmichel11 can you help with this?

@lslusarczyk
Copy link
Contributor Author

lslusarczyk commented Jan 30, 2026

@lslusarczyk Thanks for spotting this. CI was green before. We should add a regression test. @mmichel11 can you help with this?

Since this blocks graphs with llama (and probably all other non-trivial apps), could you add the regression test in a separate PR after this fix is merged?

@mmichel11
Copy link
Contributor

@lslusarczyk Thanks for spotting this. CI was green before. We should add a regression test. @mmichel11 can you help with this?

Since this blocks graphs with llama (and probably all other non-trivial apps), could you add the regression test in a separate PR after this fix is merged?

I suggest we add a test now for completeness. I've produced the issue in a small reproducer and will work it into a graph unit test on Monday.

Signed-off-by: Matthew Michel <matthew.michel@intel.com>
@mmichel11
Copy link
Contributor

@lslusarczyk I opened a PR to your fork's PR branch with a regression test: lslusarczyk#1

Add regression test for infinite loop in graph memory pool
Copy link
Member

@adamfidel adamfidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The CI failure is the same as referenced in #21097.

@adamfidel
Copy link
Member

@intel/llvm-gatekeepers Please consider merging :)

@sarnex sarnex merged commit 6726248 into intel:sycl Feb 3, 2026
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants