You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on May 9, 2024. It is now read-only.
What happens is we already store it with record_error_code inside the row function, then at the upper level we load the value to check if an error occurred, and if yes we store it back again. I discovered this while triaging the GPU hanging issue on a specific query. I wasn't sure that's always the case (even though we seem to always do it unconditionally, see createErrorCheckControlFlow), so I created this draft to check with CI.
I saw cases when row_func doesn't even get error_code but still can return a non-zero value. This happens when the number of matched rows exceeds max_matched value. In this case, we return -pos written later to error_code. I'm not sure if this is used in tests, but looks like a useful feature to interrupt and then continue execution from the last position.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.