feat: support commonjs distribution#133
Conversation
| "removeComments": true, | ||
| "baseUrl": ".", | ||
| "paths": { | ||
| "*": ["node_modules/*"] |
There was a problem hiding this comment.
Removed to allow tsup resolve .node packages correctly.
|
Thanks for this PR, @oderayi! I've spent some time considering this, as I really want to make this package work for as many people as possible, but I've been hesitant for a few reasons:
I've been looking at different ways to serve both CommonJS and ESM without switching build system, but this hasn't been successful. Also, I've been thinking about the way forward for the node community, and it seems to me that this is the time to keep moving in the ESM direction to get the entire community to a better place where we don't have to deal with the confusing situation we have now, with both CommonJS and ESM side by side. If find this article sums this up in a good way. So for all these reasons, I'm closing this PR, but know that I really appreciate the time and effort you put into it, @oderayi. I also hope you find a way to make it work, perhaps with the synchronous |
This PR adds tsup to enable distribution in CommonJS format for wider support.