-
Notifications
You must be signed in to change notification settings - Fork 923
[FEAT]: Add Support for GitHub Enterprise Rulesets #3110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
deiga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial pass. Not a complete review.
Please see if there are other parts of the PR where my comments might be applicable :)
| ReadContext: resourceGithubEnterpriseRulesetRead, | ||
| UpdateContext: resourceGithubEnterpriseRulesetUpdate, | ||
| DeleteContext: resourceGithubEnterpriseRulesetDelete, | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add Importer functionality :)
… and remove initial schemaversion
…e actor_type validation
…rise ruleset resource
…se ruleset schema
…ise ruleset schema
|
You're doing good work! I'm wondering if there are patterns from #2958 you should be copying here (for example the conditions and rules validation) |
Thanks! although I wasted a lot of time today being utterly confused of what is actually implemented and exposed in the API/golang sdk. E.g there are parts in the go sdk, which indicate that a ruleset can use the new
I can check it out and see if I can adjust it ! For the importer feature: I left it out intentionally as I was under the impression it is a feature used only in UI. Not sure who actually would use it with terraform/tofu to import json in hcl. |
Similar to the the
|
…ort and conditions
|
The Importer is functionality to enable |
Oh nevermind, yes that I will most definitely add! I thought you were referring to the importer functionality in GitHub rulesets. Oops |
Resolves #2666
Before the change?
No possibility to create or fetch rulesets at enterprise level
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Notes
testAccGithubEnterpriseRuleset_required_workflows:Error running post-test destroy, there may be dangling resources forvulnerability-alerts`. The test still works but the vulnerabtily alert seems to be not finished in time. Happy to hear feedback about this